Merge lp:~dobey/cmake-extras/add-gdbus into lp:cmake-extras
Proposed by
dobey
Status: | Merged |
---|---|
Approved by: | dobey |
Approved revision: | 67 |
Merged at revision: | 68 |
Proposed branch: | lp:~dobey/cmake-extras/add-gdbus |
Merge into: | lp:cmake-extras |
Diff against target: |
286 lines (+252/-0) 6 files modified
debian/tests/control (+10/-0) debian/tests/gdbus (+25/-0) examples/gdbus-demo/CMakeLists.txt (+50/-0) examples/gdbus-demo/main.cpp (+62/-0) examples/gdbus-demo/org.freedesktop.DBus.xml (+18/-0) src/GDbus/GDbusConfig.cmake (+87/-0) |
To merge this branch: | bzr merge lp:~dobey/cmake-extras/add-gdbus |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pete Woods | Approve | ||
Charles Kerr (community) | Approve | ||
Review via email: mp+318280@code.launchpad.net |
Commit message
Add a module for using gdbus-codegen code with cmake.
To post a comment you must log in.
LGTM. Even past the standardization into cmake-extras, the implementation has some nice cleanups compared to the roll-your-own versions in the indicators.
Optional comments inline, plus a needinfo about CMAKE_CXX_STANDARD