CMake Extras

Code review comment for lp:~dobey/cmake-extras/add-gdbus

  1. add-gdbus
  2. Merge into trunk
Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM. Even past the standardization into cmake-extras, the implementation has some nice cleanups compared to the roll-your-own versions in the indicators.

Optional comments inline, plus a needinfo about CMAKE_CXX_STANDARD

review: Needs Information

« Back to merge proposal