Code review comment for lp:~doanac/utah/uuid_check_rsyslog

On 05/16/2013 11:15 AM, Javier Collado wrote:
> I've tested with a desktop i386 image and the pass runlist and it worked fine.
> However, I have the feeling that there's some duplication in the code that is a
> little bit confusing. In particular, I've seen that the machine UUID is written
> twice to the syslog file.
>
> The reason for this is that the commands in `install-commands.jinja2` are
> written both to the late command script and also to `/etc/rc.local`. Given that
> UUID is expected to be captured during the boot sequence, I believe it should
> only be in `/etc/rc.local`, not in the late command script.

I think sending it twice is harmless. I have another branch that's
dependent on this that does some more refactoring around this area that
might be a better place to address.

On 05/16/2013 01:33 PM, Max Brustkern wrote:
 > Maybe we should move the install commands into rc.local only? I
 > think we've been discussing relying less on the preseed for a while.

I think this is what we should shoot for. I'm not totally sure we should
do it in this change though?