Code review comment for lp:~doanac/utah/uuid_check_rsyslog

Revision history for this message
Javier Collado (javier.collado) wrote :

I've tested with a desktop i386 image and the pass runlist and it worked fine.
However, I have the feeling that there's some duplication in the code that is a
little bit confusing. In particular, I've seen that the machine UUID is written
twice to the syslog file.

The reason for this is that the commands in `install-commands.jinja2` are
written both to the late command script and also to `/etc/rc.local`. Given that
UUID is expected to be captured during the boot sequence, I believe it should
only be in `/etc/rc.local`, not in the late command script.

« Back to merge proposal