Code review comment for lp:~doanac/utah/uuid_check_rsyslog
Revision history for this message
| Andy Doan (doanac) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On 05/03/2013 10:29 AM, Max Brustkern wrote:
> I have two more substantive concerns. Are we going to receive a UUID
> on systems where the wait_for_booted isn't working?
no
> Is it safe to
> change the incorrect uuid behavior from an Exception to logging an
> error? The intent of this check is to ensure we're actually running
> on the system we installed, and I don't think logging an error and
> then continuing the test is necessarily an appropriate response. We
> could consider doing a retry, but I think continuing is a problem.
so - I'm probably downplaying the importance of the UUID here.
Originally I liked this better but this is probably worth debate.
The *real* reason I shuffled this around is because this need to make an
SSH connection to the target after install gets in the way of doing an
autostart of UTAH from rc.local. So if we make a retry type thing here,
its still going to be a problem for my next planned patchset.