Code review comment for lp:~doanac/utah/run-cleanups

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I'm wondering if any of what's currently in the various scripts should be in run.py instead?

I say that because I just started working on a branch to eliminate all but one of those. Maybe we should try to land this first, and then move any extra functionality into run.py. I don't like that we're passing args in; I feel like there should be some more specific and defined thing that gets handed to run.py, and all the actual command line handling should be maybe in the script. Either that or basically everything should be in run.py, and the script should just be handling picking an inventory and getting a machine? Not sure of the best approach for that, and we can just leave it as is for now if nothing else is compelling.

« Back to merge proposal