Code review comment for lp:~doanac/utah/bug1158743

Revision history for this message
Andy Doan (doanac) wrote :

On 03/26/2013 12:35 PM, Javier Collado wrote:
> - Exceptions
>
> When getting the process object, TypeError and ValueError exceptions are
> caught:
> except (psutil.error.NoSuchProcess, TypeError, ValueError):
>
> However, I think they shouldn't be caught since I'd like to get an exception
> when I don't pass the right parameter type as in:
> pid_in_use('string')
>
> Otherwise, I misuse is not noticed by the end user.

Is this going to cause a possible regression that we need to test for?

@max - I think you suggested this, but i don't recall why

« Back to merge proposal