Code review comment for lp:~doanac/ubuntu-test-cases/simplify-touch

Revision history for this message
Paul Larson (pwlars) wrote :

+1 this all looks good.

Some random comments (nothing that has to be fixed now):
* Yeah, I had noticed that one time about the fact that we use -s on some adb commands and not other. The -s is actually not needed as long as we have ANDROID_SERIAL exported to the environment. If we ever quit doing that, then we need to use the -s though. We should probably be consistent here, but that's a cleanup thing for another time.
* We can actually remove the workaround (which was previously commented out but left in place by me because we didn't know if we would get asked to turn it back on again) for the ueventd bug. That fix went in *today*! \o/

review: Approve

« Back to merge proposal