Code review comment for lp:~doanac/ubuntu-ci-services-itself/json-jsonp-status

Revision history for this message
Andy Doan (doanac) wrote :

On 03/03/2014 03:10 AM, Evan Dandrea wrote:
> 110 +@hooks.hook('json_status-relation-changed')
> 111 +def json_status_relation_changed():
> 112 + json_status_relation_joined()
>
> Minor nit, but couldn't you just decorate json_status_relation_joined() with hooks.hook('json_status-relation-changed')?

I wasn't positive if was safe with the hooks.hook decorator to have it
twice for a function. I'm re-doplying this morning, so it should be easy
to find out :)

« Back to merge proposal