In addition to eventually refactoring the queue helpers into a common utils directory as you mentioned:
- when refactoring, be sure to split the tests in branch-source-builder/bsbuilder/tests/test_utils.py.
- branch-source-builder/setup.py is not executable
- wsgi.py starts the server on port 8080, but prints '8000'. Is there a guideline for choosing ports? My local jenkins runs on 8080 also so I can't start this locally as is.
Not having done a REST app before, I don't have a lot of input. I'm in favor of how you're doing this, but not familiar with any alternatives. I did spend extra time reviewing the queue setup and like what's going on there.
In addition to eventually refactoring the queue helpers into a common utils directory as you mentioned:
- when refactoring, be sure to split the tests in branch- source- builder/ bsbuilder/ tests/test_ utils.py. source- builder/ setup.py is not executable
- branch-
- wsgi.py starts the server on port 8080, but prints '8000'. Is there a guideline for choosing ports? My local jenkins runs on 8080 also so I can't start this locally as is.
Not having done a REST app before, I don't have a lot of input. I'm in favor of how you're doing this, but not familiar with any alternatives. I did spend extra time reviewing the queue setup and like what's going on there.
Want to do some local testing before approving.