Merge lp:~doanac/qa-dashboard/smoke-pull-test into lp:qa-dashboard

[Andy Doan]

add some unit testing for the smoke pull script

validates job pattern matching, extract_data, and utah log discovery

I'm about to add the ability to parse multiple utah results from a single jenkins job. To set the stage for that, I wanted to first add some simple unit-testing to help validate the areas in-which I'll be changing code.

This change adds some testing on our smoke pull script.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:696
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/273/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/273/rebuild

review: Approve (continuous-integration)

[Joe Talbott (joetalbott)]

review: Approve

=== modified file 'smokeng/management/commands/jenkins_pull_smokeng.py'
--- smokeng/management/commands/jenkins_pull_smokeng.py	2013-12-02 16:37:50 +0000
+++ smokeng/management/commands/jenkins_pull_smokeng.py	2013-12-04 03:49:14 +0000
@@ -289,9 +289,9 @@
 
         logs = []
 
+        utah_log_regex = re.compile(ur'^(clientlogs\/|)utah.*.yaml')
         for artifact in artifacts:
             path = artifact['relativePath']
-            utah_log_regex = re.compile(ur'^(clientlogs\/|)utah.*.yaml')
             logging.debug(path)
             if utah_log_regex.match(path):
                 logs.append(artifact)
 
=== modified file 'smokeng/tests.py'
--- smokeng/tests.py	2013-11-21 16:58:17 +0000
+++ smokeng/tests.py	2013-12-04 03:49:14 +0000
@@ -392,6 +392,67 @@
         self.assertFalse(self.command._has_media_info(self.build))
 
 
+class TestPullScript(TestCase):
+    def testJobNames(self):
+        '''ensure the job_regex matches everything it should.'''
+        good = [
+            'trusty-touch-mako-smoke-dropping-letters-app-autopilot',
+            'saucy-touch_ro-maguro-smoke-master',
+            'precise-server-amd64-smoke-default',
+            'trusty-desktop-i386-smoke-default',
+        ]
+        bad = [
+            'foo-touch_ro-maguro-smoke-master',  # no such release
+            'trusty-touch_ro-maguro-smoke',      # no test defined
+            'trusty-desktop-i386-smoke-static_validation',
+        ]
+
+        for x in good:
+            self.assertIsNotNone(Command.job_regex.match(x))
+        for x in bad:
+            self.assertIsNone(Command.job_regex.match(x))
+
+    def _extract_matches(self, name, expected):
+        c = Command()
+        c.extract_data(name)
+        self.assertDictEqual(expected, c.install_data)
+
+    def testExtractData(self):
+        '''ensure the extract data can populate from the job name.'''
+        patterns = [
+            ('saucy-touch_ro-maguro-smoke-master', {
+                'arch': 'maguro',
+                'release': 'saucy',
+                'test_name': 'master',
+                'variant': 'touch_ro',
+            }),
+            ('trusty-touch-mako-smoke-friends-app-autopilot', {
+                'arch': 'mako',
+                'release': 'trusty',
+                'test_name': 'friends-app-autopilot',
+                'variant': 'touch',
+            }),
+        ]
+        for name, data in patterns:
+            self._extract_matches(name, data)
+
+    def testUtahLogs(self):
+        '''ensure we find the proper patterns of logfile names'''
+        good = [
+            {'relativePath': 'utah.yaml'},
+            {'relativePath': 'clientlogs/utah.yaml'},
+        ]
+        bad = [
+            {'relativePath': 'foo/utah.yaml'},
+            {'relativePath': 'clientlogs/utah-host.yml'},
+            {'relativePath': 'clientlogs/test1/utah.yaml'},
+            {'relativePath': 'clientlogs/test2/utah.yaml'},
+        ]
+        c = Command()
+        logs = c._get_utah_logs(good + bad)
+        self.assertListEqual(good, logs)
+
+
 class TestSmokeConfig(TestCase):
 
     def setUp(self):