Code review comment for lp:~doanac/linaro-image-tools/slash-proc-spam-version2

Revision history for this message
Guilherme Salgado (salgado) wrote :

This looks great!

It'd be nice to have at least one test, just to show that run_local_atexit_funcs() is called even if install_hwpack() raises an exception. To do that you could easily use MockSomethingFixture to mock both functions, having the former just change an instance variable so you know it was called and the latter just raise an exception. After that you'd just call install_hwpacks(), but you'll also need to mock sys.stdout and our custom Popen (the existing test_install_hwpacks method there should work as an example)

review: Approve

« Back to merge proposal