Merge lp:~doanac/lava-scheduler/5-longest-jobs into lp:lava-scheduler

Proposed by Andy Doan
Status: Merged
Approved by: Michael Hudson-Doyle
Approved revision: 199
Merged at revision: 198
Proposed branch: lp:~doanac/lava-scheduler/5-longest-jobs
Merge into: lp:lava-scheduler
Diff against target: 43 lines (+17/-0)
2 files modified
lava_scheduler_app/templates/lava_scheduler_app/reports.html (+11/-0)
lava_scheduler_app/views.py (+6/-0)
To merge this branch: bzr merge lp:~doanac/lava-scheduler/5-longest-jobs
Reviewer Review Type Date Requested Status
Linaro Validation Team Pending
Review via email: mp+115422@code.launchpad.net

Description of the change

simple report to show 5 longest running jobs

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I think you should consider the case when there are no running jobs --
it does happen! -- and just display "no jobs running" or something in
that situation.

Cheers,
mwh

Andy Doan <email address hidden> writes:

> Andy Doan has proposed merging lp:~doanac/lava-scheduler/5-longest-jobs into lp:lava-scheduler.
>
> Requested reviews:
> Linaro Validation Team (linaro-validation)
>
> For more details, see:
> https://code.launchpad.net/~doanac/lava-scheduler/5-longest-jobs/+merge/115422
>
> simple report to show 5 longest running jobs
> --
> https://code.launchpad.net/~doanac/lava-scheduler/5-longest-jobs/+merge/115422
> You are subscribed to branch lp:lava-scheduler.
> === modified file 'lava_scheduler_app/templates/lava_scheduler_app/reports.html'
> --- lava_scheduler_app/templates/lava_scheduler_app/reports.html 2012-06-16 03:48:18 +0000
> +++ lava_scheduler_app/templates/lava_scheduler_app/reports.html 2012-07-17 19:18:25 +0000
> @@ -142,4 +142,11 @@
> </script>
> </div>
>
> +<h2>Longest Running Jobs</h2>
> +<ul>
> +{% for job in long_running %}
> + <li><a href="{{job.get_absolute_url}}">{{job.id}}</a>: {{job.start_time}}</li>
> +{% endfor %}
> +</ul>
> +
> {% endblock %}
>
> === modified file 'lava_scheduler_app/views.py'
> --- lava_scheduler_app/views.py 2012-06-26 01:49:31 +0000
> +++ lava_scheduler_app/views.py 2012-07-17 19:18:25 +0000
> @@ -232,6 +232,11 @@
> for week in reversed(range(10)):
> health_week_report.append(job_report(week*-7-7, week*-7, True))
> job_week_report.append(job_report(week*-7-7, week*-7, False))
> +
> + long_running = TestJob.objects.filter(
> + status__in = [TestJob.RUNNING, TestJob.CANCELING]
> + ).order_by('start_time')[:5]
> +
> return render_to_response(
> "lava_scheduler_app/reports.html",
> {
> @@ -239,6 +244,7 @@
> 'health_day_report': health_day_report,
> 'job_week_report': job_week_report,
> 'job_day_report': job_day_report,
> + 'long_running': long_running,
> 'bread_crumb_trail': BreadCrumbTrail.leading_to(index),
> },
> RequestContext(request))

199. By Andy Doan

handle case where no jobs are running

Revision history for this message
Andy Doan (doanac) wrote :

should be better now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_scheduler_app/templates/lava_scheduler_app/reports.html'
2--- lava_scheduler_app/templates/lava_scheduler_app/reports.html 2012-06-16 03:48:18 +0000
3+++ lava_scheduler_app/templates/lava_scheduler_app/reports.html 2012-07-17 22:27:02 +0000
4@@ -142,4 +142,15 @@
5 </script>
6 </div>
7
8+<h2>Longest Running Jobs</h2>
9+{% if long_running|length_is:"0" %}
10+There are no running jobs.
11+{% else %}
12+<ul>
13+{% for job in long_running %}
14+ <li><a href="{{job.get_absolute_url}}">{{job.id}}</a>: {{job.start_time}}</li>
15+{% endfor %}
16+</ul>
17+{% endif %}
18+
19 {% endblock %}
20
21=== modified file 'lava_scheduler_app/views.py'
22--- lava_scheduler_app/views.py 2012-06-26 01:49:31 +0000
23+++ lava_scheduler_app/views.py 2012-07-17 22:27:02 +0000
24@@ -232,6 +232,11 @@
25 for week in reversed(range(10)):
26 health_week_report.append(job_report(week*-7-7, week*-7, True))
27 job_week_report.append(job_report(week*-7-7, week*-7, False))
28+
29+ long_running = TestJob.objects.filter(
30+ status__in = [TestJob.RUNNING, TestJob.CANCELING]
31+ ).order_by('start_time')[:5]
32+
33 return render_to_response(
34 "lava_scheduler_app/reports.html",
35 {
36@@ -239,6 +244,7 @@
37 'health_day_report': health_day_report,
38 'job_week_report': job_week_report,
39 'job_day_report': job_day_report,
40+ 'long_running': long_running,
41 'bread_crumb_trail': BreadCrumbTrail.leading_to(index),
42 },
43 RequestContext(request))

Subscribers

People subscribed via source and target branches