Code review comment for lp:~doanac/lava-dispatcher/serial-delay

Antonio Terceiro <email address hidden> writes:

> On Sat, Dec 15, 2012 at 12:16:23AM -0000, Andy Doan wrote:
>> === modified file 'lava_dispatcher/utils.py'
>> --- lava_dispatcher/utils.py 2012-11-26 19:30:28 +0000
>> +++ lava_dispatcher/utils.py 2012-12-15 00:15:28 +0000
>> @@ -163,13 +163,23 @@
>>
>> class logging_spawn(pexpect.spawn):
>>
>> + def __init__(self, command, timeout=30, logfile=None):
>> + pexpect.spawn.__init__(
>> + self, command, timeout=timeout, logfile=logfile)
>> +
>> + # serial can be slow, races do funny things, so increase delay
>> + self.delaybeforesend = 0.05
>> +
>
> Maybe we want this to be configurable instead of hardcoded?

I'll review that branch really quickly!