Code review comment for lp:~doanac/lava-dispatcher/serial-delay

Agree. That way we could also experimenting to get it down to a minimum.

Sent from my Aldis Lamp

On 17 Dec 2012, at 14:34, Antonio Terceiro <email address hidden> wrote:

> On Sat, Dec 15, 2012 at 12:16:23AM -0000, Andy Doan wrote:
>> === modified file 'lava_dispatcher/utils.py'
>> --- lava_dispatcher/utils.py 2012-11-26 19:30:28 +0000
>> +++ lava_dispatcher/utils.py 2012-12-15 00:15:28 +0000
>> @@ -163,13 +163,23 @@
>>
>> class logging_spawn(pexpect.spawn):
>>
>> + def __init__(self, command, timeout=30, logfile=None):
>> + pexpect.spawn.__init__(
>> + self, command, timeout=timeout, logfile=logfile)
>> +
>> + # serial can be slow, races do funny things, so increase delay
>> + self.delaybeforesend = 0.05
>> +
>
> Maybe we want this to be configurable instead of hardcoded?
>
> --
> Antonio Terceiro
> Software Engineer - Linaro
> http://www.linaro.org
>
> https://code.launchpad.net/~doanac/lava-dispatcher/serial-delay/+merge/140050
> You are reviewing the proposed merge of lp:~doanac/lava-dispatcher/serial-delay into lp:lava-dispatcher.