Code review comment for lp:~doanac/lava-dispatcher/config-finding-fix

Revision history for this message
Antonio Terceiro (terceiro) wrote :

On Sat, Dec 29, 2012 at 04:37:22PM -0000, Andy Doan wrote:
> On 12/21/2012 08:01 AM, Antonio Terceiro wrote:
> > Do you keep the bin/ directory of the virtualenv in your $PATH?
> >
> > I don't, and added this to my bashrc:
> >
> > alias init-lava='. ~/src/lava/.virtualenv/lava/bin/activate'
> >
> > When I want to run lava commands I just to run `init-lava` before.
>
> The problem is that people are currently installing lava, and then
> expecting "lava dispatch" or "lava devices" to work, and they don't.
> This patch makes it work out of the box without requiring the user to
> alter their environment.

ok, got it now.

 +1

--
Antonio Terceiro
Software Engineer - Linaro
http://www.linaro.org

« Back to merge proposal