Prometheus libvirt exporter charm

Code review comment for ~dmzoneill/charm-prometheus-libvirt-exporter:dev/q2-20

  1. Git
  2. lp:~dmzoneill/charm-prometheus-libvirt-exporter
  3. dev/q2-20
  4. Merge into master
Revision history for this message
Alvaro Uria (aluria) wrote :

There is a dashboard that was initially included in charm-grafana [1]. However, the approach followed in this MP (share dashboards via relations) is the end goal. Please have a look to the mentioned charm-grafana MP because it uses the "_input" attribute to rewrite the datasources. Currently, it is hardcoded to "prometheus - Juju generated datasource". However, the Juju application may be named "prometheus2". In such case, the datasource name should be "prometheus2 - Juju generated datasource".

1. https://code.launchpad.net/~llama-charmers/charm-grafana/+git/charm-grafana/+merge/380965

« Back to merge proposal