Code review comment for ~dmzoneill/charm-prometheus-libvirt-exporter:dev/q2-20
Revision history for this message
| Chris MacNaughton (chris.macnaughton) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
General code review
===================
See inline comments for an overall code review.
The code has lint checking which it passes
Unit testing coverage
=======
This charm change has no unit test coverage. As such, any new functionality introduced, and the potential impact of this change to existing behavior has not been assessed by the reviewer.
Functional testing coverage
=======
The cham has basic functional coverage of all series that the charm supports