Thanks for updating this and the other branches.
To further polish you might mention the name of the patch in the changelog.
Like:
* d/p/PAOS-Do-not-populate-Destination-attribute.patch: Do not populate "Destination" attribute (LP: #1833299)
Further you don't need the [ Name ] on top of the changes, a sponsor would create that if he replaces your name at the bottom.
But both of these are "style" and no show stopper.
It LGTM now.
I'll +1 on all MPs but you'll also need a SRU template on the bug before this can be sponsored for pre-Eoan.
Thanks for updating this and the other branches. Do-not- populate- Destination- attribute. patch: Do not populate "Destination" attribute (LP: #1833299)
To further polish you might mention the name of the patch in the changelog.
Like:
* d/p/PAOS-
Further you don't need the [ Name ] on top of the changes, a sponsor would create that if he replaces your name at the bottom.
But both of these are "style" and no show stopper.
It LGTM now.
I'll +1 on all MPs but you'll also need a SRU template on the bug before this can be sponsored for pre-Eoan.