Merge lp:~dmitriis/charms/trusty/contrail-analytics/trunk into lp:~sdn-charmers/charms/trusty/contrail-analytics/trunk

Proposed by Dmitrii Shcherbakov
Status: Merged
Merged at revision: 40
Proposed branch: lp:~dmitriis/charms/trusty/contrail-analytics/trunk
Merge into: lp:~sdn-charmers/charms/trusty/contrail-analytics/trunk
Diff against target: 60 lines (+23/-4)
3 files modified
hooks/contrail_analytics_hooks.py (+7/-1)
hooks/contrail_analytics_utils.py (+10/-3)
templates/contrail-analytics-api.conf (+6/-0)
To merge this branch: bzr merge lp:~dmitriis/charms/trusty/contrail-analytics/trunk
Reviewer Review Type Date Requested Status
Robert Ayres (community) Approve
Ante Karamatić Pending
Review via email: mp+320154@code.launchpad.net

Description of the change

rbac support (rebased)

To post a comment you must log in.
Revision history for this message
Robert Ayres (robert-ayres) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/contrail_analytics_hooks.py'
--- hooks/contrail_analytics_hooks.py 2017-03-10 13:02:06 +0000
+++ hooks/contrail_analytics_hooks.py 2017-03-17 09:27:51 +0000
@@ -160,7 +160,13 @@
160160
161@hooks.hook("contrail-api-relation-changed")161@hooks.hook("contrail-api-relation-changed")
162def contrail_api_changed():162def contrail_api_changed():
163 if not relation_get("port"):163 required_keys = ['port']
164 # only need to check for role availability if
165 # rbac is explicitly set
166 if relation_get('rbac'):
167 required_keys.append('cloud-admin-role')
168
169 if not all(relation_get(k) for k in required_keys):
164 log("Relation not ready")170 log("Relation not ready")
165 return171 return
166 contrail_api_relation()172 contrail_api_relation()
167173
=== modified file 'hooks/contrail_analytics_utils.py'
--- hooks/contrail_analytics_utils.py 2017-03-10 13:02:06 +0000
+++ hooks/contrail_analytics_utils.py 2017-03-17 09:27:51 +0000
@@ -113,10 +113,17 @@
113def contrail_api_ctx():113def contrail_api_ctx():
114 ctxs = [ { "api_server": vip if vip \114 ctxs = [ { "api_server": vip if vip \
115 else gethostbyname(relation_get("private-address", unit, rid)),115 else gethostbyname(relation_get("private-address", unit, rid)),
116 "api_port": port }116 "api_port": port,
117 "rbac": rbac,
118 "cloud_admin_role": adminrole
119 }
117 for rid in relation_ids("contrail-api")120 for rid in relation_ids("contrail-api")
118 for unit, port, vip in121 for unit, port, vip, rbac, adminrole in
119 ((unit, relation_get("port", unit, rid), relation_get("vip", unit, rid))122 ((unit,
123 relation_get("port", unit, rid),
124 relation_get("vip", unit, rid),
125 relation_get("rbac", unit, rid),
126 relation_get("cloud-admin-role", unit, rid))
120 for unit in related_units(rid))127 for unit in related_units(rid))
121 if port ]128 if port ]
122 return ctxs[0] if ctxs else {}129 return ctxs[0] if ctxs else {}
123130
=== modified file 'templates/contrail-analytics-api.conf'
--- templates/contrail-analytics-api.conf 2017-01-31 12:44:08 +0000
+++ templates/contrail-analytics-api.conf 2017-03-17 09:27:51 +0000
@@ -17,6 +17,12 @@
17api_server = {{ api_server ~ ":" ~ api_port if api_server and api_port }}17api_server = {{ api_server ~ ":" ~ api_port if api_server and api_port }}
18{%- endif %}18{%- endif %}
1919
20{% if rbac -%}
21aaa_mode = no-auth
22cloud_admin_role = {{ cloud_admin_role }}
23
24{% endif %}
25
20[DISCOVERY]26[DISCOVERY]
21disc_server_ip = {{ disc_server_ip }}27disc_server_ip = {{ disc_server_ip }}
22disc_server_port = {{ disc_server_port }}28disc_server_port = {{ disc_server_port }}

Subscribers

People subscribed via source and target branches