Merge lp:~dktrkranz/synaptic/manual into lp:synaptic

Proposed by Luca Falavigna
Status: Merged
Merged at revision: 1798
Proposed branch: lp:~dktrkranz/synaptic/manual
Merge into: lp:synaptic
Diff against target: 35 lines (+7/-1)
2 files modified
common/rpackageview.cc (+2/-1)
debian/changelog (+5/-0)
To merge this branch: bzr merge lp:~dktrkranz/synaptic/manual
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+42026@code.launchpad.net

Description of the change

* common/rpackageview.cc:
  - Do not display base packages in manual view.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for your branch.

I have to say that I'm a bit in split minds about it. Technically "Install (manual)" is no longer quite correct with it. But I see the value in protecting users from removing important stuff and apt will also not garbage collect stuff in manual mode.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'common/rpackageview.cc'
--- common/rpackageview.cc 2010-05-04 13:53:00 +0000
+++ common/rpackageview.cc 2010-11-28 00:25:41 +0000
@@ -151,7 +151,8 @@
151 }151 }
152152
153 if ((flags & RPackage::FInstalled) &&153 if ((flags & RPackage::FInstalled) &&
154 !(flags & RPackage::FIsAuto))154 !(flags & RPackage::FIsAuto) &&
155 !(flags & RPackage::FImportant))
155 {156 {
156 str = _("Installed (manual)");157 str = _("Installed (manual)");
157 _view[str].push_back(pkg);158 _view[str].push_back(pkg);
158159
=== modified file 'debian/changelog'
--- debian/changelog 2010-11-23 16:43:38 +0000
+++ debian/changelog 2010-11-28 00:25:41 +0000
@@ -1,5 +1,6 @@
1synaptic (0.70~pre3) UNRELEASED; urgency=low1synaptic (0.70~pre3) UNRELEASED; urgency=low
2 2
3 [ Michael Vogt ]
3 * gtk/rgmainwindow.cc:4 * gtk/rgmainwindow.cc:
4 - show message in quick search label if no apt-xapian-index can5 - show message in quick search label if no apt-xapian-index can
5 be found6 be found
@@ -7,6 +8,10 @@
7 * po/hu.po:8 * po/hu.po:
8 - updated, thanks to Gabor Kum 9 - updated, thanks to Gabor Kum
9 10
11 [ Luca Falavigna ]
12 * common/rpackageview.cc:
13 - Do not display base packages in manual view.
14
10 -- Michael Vogt <michael.vogt@ubuntu.com> Wed, 10 Nov 2010 19:44:31 +010015 -- Michael Vogt <michael.vogt@ubuntu.com> Wed, 10 Nov 2010 19:44:31 +0100
1116
12synaptic (0.70~pre2) unstable; urgency=low17synaptic (0.70~pre2) unstable; urgency=low

Subscribers

People subscribed via source and target branches

to status/vote changes: