I would be flattered to have my code merged, so I will write some tests for untested things.
Should I request a merge myself, once that is done?
David
On Thu, Sep 22, 2011 at 2:39 PM, Zooko O'Whielacronx <email address hidden> wrote: > Review: Needs Fixing > > Oh, and also a lack of tests for all of the other changes in the branch. I would favor adding tests before merging, actually, so I guess I should now undo my "suggest merge" action? > -- > https://code.launchpad.net/~dkeeney/txaws/add-multipart-upload/+merge/76647 > You are the owner of lp:~dkeeney/txaws/add-multipart-upload. >
« Back to merge proposal
I would be flattered to have my code merged, so I will write some
tests for untested things.
Should I request a merge myself, once that is done?
David
On Thu, Sep 22, 2011 at 2:39 PM, Zooko O'Whielacronx <email address hidden> wrote: /code.launchpad .net/~dkeeney/ txaws/add- multipart- upload/ +merge/ 76647
> Review: Needs Fixing
>
> Oh, and also a lack of tests for all of the other changes in the branch. I would favor adding tests before merging, actually, so I guess I should now undo my "suggest merge" action?
> --
> https:/
> You are the owner of lp:~dkeeney/txaws/add-multipart-upload.
>