Code review comment for lp:~djaler1/screenshot-tool/fix-1670010

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

@Kirill: I like the separate get_timeout function, however I find that with a delay setting of zero the screenshot is sometimes unsuccessful or corrupted, especially with redaction . I am not sure of the reason but you could try setting a non-zero minimum value returned from get_timeout () (although it would be better to understand the real reason). I think it would be more convenient for timeout to be consistently in milliseconds.

Alternatively, you could revert the minimum (reliable) delay to 1 second and address the problems with zero delay in another branch.

review: Needs Fixing (function)

« Back to merge proposal