Merge ~djacobs98/checkbox-iiotg/+git/checkbox-iiotg-classic:patch-for-pmu into ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master

Proposed by Doug Jacobs
Status: Needs review
Proposed branch: ~djacobs98/checkbox-iiotg/+git/checkbox-iiotg-classic:patch-for-pmu
Merge into: ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master
Diff against target: 51 lines (+34/-0)
2 files modified
patches/0001-Removed-hardcoded-directories.patch (+25/-0)
snap/snapcraft.yaml (+9/-0)
Reviewer Review Type Date Requested Status
Vic Liu Needs Information
StanleyHuang Pending
Review via email: mp+424382@code.launchpad.net

Commit message

Add: Add patch to remove the hardcoded directories in Makefile.globals.inc in perf-event-tests

PMU uses the test suite perf-event-tests for testing. This test suite uses hardcoded directories that cause problems with Snapcraft. This patch will remove those directories allowing Snapcraft to pass in parameters for them instead.

To post a comment you must log in.
Revision history for this message
Vic Liu (zongminl) wrote :

Let's leave this MR here temporarily until we can get the perf-event-tests sorted out

Unmerged commits

5b60b26... by Doug Jacobs

Patch to remove hardcoded directories in Makefile.globls.inc for perf-event-tests
(fixed a typo & whitespace error - patch now applies without error)

647ba22... by Doug Jacobs

Trying to get snapcraft.yaml to work.

4f77ba1... by Doug Jacobs

Add: Adding perf_events_tests to snapcraft.yaml

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/patches/0001-Removed-hardcoded-directories.patch b/patches/0001-Removed-hardcoded-directories.patch
0new file mode 1006440new file mode 100644
index 0000000..f5b0726
--- /dev/null
+++ b/patches/0001-Removed-hardcoded-directories.patch
@@ -0,0 +1,25 @@
1From 177537e5ca910f3252bc9e0a54b3d843d5095531 Mon Sep 17 00:00:00 2001
2From: djacobs98 <douglas.jacobs@canonical.com>
3Date: Fri, 10 Jun 2022 17:38:06 +0800
4Subject: [PATCH] Removed hardcoded directories
5
6---
7 Makefile.globals.inc | 4 ++--
8 1 file changed, 2 insertions(+), 2 deletions(-)
9
10diff --git a/Makefile.globals.inc b/Makefile.globals.inc
11index 747ac16..a519ee9 100644
12--- a/Makefile.globals.inc
13+++ b/Makefile.globals.inc
14@@ -10,6 +10,6 @@ OBJCOPY = $(CROSS_COMPILE)objcopy
15 OBJDUMP = $(CROSS_COMPILE)objdump
16 RANLIB = $(CROSS_COMPILE)ranlib
17
18-INSTALL = /usr/bin/install
19+#INSTALL = /usr/bin/install
20
21-prefix = /opt/perf_event_tests
22+#prefix = /opt/perf_event_tests
23--
242.25.1
25
diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
index eb77bb1..97af8e8 100644
--- a/snap/snapcraft.yaml
+++ b/snap/snapcraft.yaml
@@ -33,6 +33,15 @@ passthrough:
33 command-chain: [bin/wrapper_local]33 command-chain: [bin/wrapper_local]
3434
35parts:35parts:
36 perf-event-tests:
37 plugin: make
38 source: https://github.com/deater/perf_event_tests
39 source-type: git
40 override-build: |
41 export INSTALL=$SNAPCRAFT_PART_INSTALL
42 export prefix=$SNAPCRAFT_PRIME
43 #snapcraftctl build
44 make prefix=$SNAPCRAFT_PART_INSTALL
36 rpc:45 rpc:
37 plugin: go46 plugin: go
38 go-channel: ""47 go-channel: ""

Subscribers

People subscribed via source and target branches