Merge ~djacobs98/checkbox-iiotg/+git/checkbox-iiotg-classic:patch-for-pmu into ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master

Proposed by Doug Jacobs
Status: Needs review
Proposed branch: ~djacobs98/checkbox-iiotg/+git/checkbox-iiotg-classic:patch-for-pmu
Merge into: ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master
Diff against target: 51 lines (+34/-0)
2 files modified
patches/0001-Removed-hardcoded-directories.patch (+25/-0)
snap/snapcraft.yaml (+9/-0)
Reviewer Review Type Date Requested Status
Vic Liu Needs Information
StanleyHuang Pending
Review via email: mp+424382@code.launchpad.net

Commit message

Add: Add patch to remove the hardcoded directories in Makefile.globals.inc in perf-event-tests

PMU uses the test suite perf-event-tests for testing. This test suite uses hardcoded directories that cause problems with Snapcraft. This patch will remove those directories allowing Snapcraft to pass in parameters for them instead.

To post a comment you must log in.
Revision history for this message
Vic Liu (zongminl) wrote :

Let's leave this MR here temporarily until we can get the perf-event-tests sorted out

Unmerged commits

5b60b26... by Doug Jacobs

Patch to remove hardcoded directories in Makefile.globls.inc for perf-event-tests
(fixed a typo & whitespace error - patch now applies without error)

647ba22... by Doug Jacobs

Trying to get snapcraft.yaml to work.

4f77ba1... by Doug Jacobs

Add: Adding perf_events_tests to snapcraft.yaml

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/patches/0001-Removed-hardcoded-directories.patch b/patches/0001-Removed-hardcoded-directories.patch
2new file mode 100644
3index 0000000..f5b0726
4--- /dev/null
5+++ b/patches/0001-Removed-hardcoded-directories.patch
6@@ -0,0 +1,25 @@
7+From 177537e5ca910f3252bc9e0a54b3d843d5095531 Mon Sep 17 00:00:00 2001
8+From: djacobs98 <douglas.jacobs@canonical.com>
9+Date: Fri, 10 Jun 2022 17:38:06 +0800
10+Subject: [PATCH] Removed hardcoded directories
11+
12+---
13+ Makefile.globals.inc | 4 ++--
14+ 1 file changed, 2 insertions(+), 2 deletions(-)
15+
16+diff --git a/Makefile.globals.inc b/Makefile.globals.inc
17+index 747ac16..a519ee9 100644
18+--- a/Makefile.globals.inc
19++++ b/Makefile.globals.inc
20+@@ -10,6 +10,6 @@ OBJCOPY = $(CROSS_COMPILE)objcopy
21+ OBJDUMP = $(CROSS_COMPILE)objdump
22+ RANLIB = $(CROSS_COMPILE)ranlib
23+
24+-INSTALL = /usr/bin/install
25++#INSTALL = /usr/bin/install
26+
27+-prefix = /opt/perf_event_tests
28++#prefix = /opt/perf_event_tests
29+--
30+2.25.1
31+
32diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
33index eb77bb1..97af8e8 100644
34--- a/snap/snapcraft.yaml
35+++ b/snap/snapcraft.yaml
36@@ -33,6 +33,15 @@ passthrough:
37 command-chain: [bin/wrapper_local]
38
39 parts:
40+ perf-event-tests:
41+ plugin: make
42+ source: https://github.com/deater/perf_event_tests
43+ source-type: git
44+ override-build: |
45+ export INSTALL=$SNAPCRAFT_PART_INSTALL
46+ export prefix=$SNAPCRAFT_PRIME
47+ #snapcraftctl build
48+ make prefix=$SNAPCRAFT_PART_INSTALL
49 rpc:
50 plugin: go
51 go-channel: ""

Subscribers

People subscribed via source and target branches