Code review comment for lp:~divmod-dev/divmod.org/829879-pypy-finalization-semantics

Revision history for this message
Laurens Van Houtven (lvh) wrote :

I'm not sure it really introduces any *new* ones: it just keeps the old one. (I only count three assert statements in the diff: one is just diff context; the other two are in the old and new versions of the "uncache" method -- that's the old one being kept.)

That doesn't mean changing the assertion to something else isn't a good idea, of course. That said, this is probably the minimal change that closes this ticket. Would you be okay with the assertions being changed in a different ticket? If you'd like, I will file a bug for and fix it, assuming that gets this ticket moving along :)

« Back to merge proposal