Merge lp:~divmod-dev/ into

Proposed by Tristan Seligmann
Status: Needs review
Proposed branch: lp:~divmod-dev/
Merge into:
Diff against target: 20 lines (+2/-2)
1 file modified
Mantissa/xmantissa/ (+2/-2)
To merge this branch: bzr merge lp:~divmod-dev/
Reviewer Review Type Date Requested Status
Jonathan Jacobs Needs Information
Review via email:
To post a comment you must log in.
Revision history for this message
Jonathan Jacobs (jjacobs) wrote :

Doesn't this break compatibility with the previous version of cssutils? I think you might want to write your own replaceUrls in the case where replaceUrls cannot be imported from cssutils.

review: Needs Information
Revision history for this message
Tristan Seligmann (mithrandi) wrote :

The change in question was made in cssutils 0.9.5b1, released in 2008. This is older than the version in Debian squeeze, so it is unlikely that anyone is using Mantissa with a version of cssutils that still has the old API; thus I don't think there's much point in introducing fallback logic.

Unmerged revisions

2712. By Tristan Seligmann

Use the new API.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Mantissa/xmantissa/'
--- Mantissa/xmantissa/ 2009-07-08 01:51:14 +0000
+++ Mantissa/xmantissa/ 2013-08-05 03:37:23 +0000
@@ -14,7 +14,7 @@
14from zope.interface import implements14from zope.interface import implements
17 from cssutils import CSSParser17 from cssutils import CSSParser, replaceUrls
18 CSSParser18 CSSParser
19except ImportError:19except ImportError:
20 CSSParser = None20 CSSParser = None
@@ -476,7 +476,7 @@
476 stylesheet = ''.join(self._buffer)476 stylesheet = ''.join(self._buffer)
477 parser = CSSParser()477 parser = CSSParser()
478 css = parser.parseString(stylesheet)478 css = parser.parseString(stylesheet)
479 css.replaceUrls(self._replace)479 replaceUrls(css, self._replace)
480 self.request.write(css.cssText)480 self.request.write(css.cssText)
481 return self.request.finish()481 return self.request.finish()


People subscribed via source and target branches

to all changes: