Merge ~dirksu/plainbox-provider-checkbox:check_wifi6e into plainbox-provider-checkbox:master

[Dirk Su]

Check if wifi6e 6GHz band enabled with Kernel under 5.15 or Ubuntu under 20.04

802.11ax 6GHz band is get through https://code.launchpad.net/~dirksu/plainbox-provider-resource/+git/plainbox-provider-resource/+merge/416708

[Sylvain Pineau (sylvain-pineau)]

The way you're parsing iw output should be added to the existing https://git.launchpad.net/plainbox-provider-resource/tree/jobs/resource.pxu#n268 resource job wireless_sta_protocol (Station supported protocols as opposed to AP mode).

I've already added some logic to guess from iw output if ax is supported via MCS 0-11.

I think you can add a new property to this resource to add info about the 6GHz support

review: Needs Fixing

[Sylvain Pineau (sylvain-pineau)]

what's the problem with "6GHz band enabled with kernel less then 5.15" ? please elaborate on why such new job is needed? what are the impacts if it fails?

review: Needs Information

[Kai-Chuan Hsieh (kchsieh)]

> what's the problem with "6GHz band enabled with kernel less then 5.15" ?
> please elaborate on why such new job is needed? what are the impacts if it
> fails?

ubuntu kernel under 5.15 are dedicated for focal and previous series, those series has no full 6GHz stack support in user space which leads device scan 6GHz and see the AP but not be able to connect to it. Also, the cfg80211 patch of 6GHz support is not completed for kernel < 5.15, so we think we should disable all wireless 6GHz scan capability at this moment, in case any unexpected crash.

The user space support for wifi 6e has been included in jammy, however, all certified devices enabled by <=5.14 kernel was not certified 6GHz regulatory, we think it should be still disabled when they upgrade to 5.15 kernel jammy too, in case, we break any country's regulation.

When the job fail, it indicates that the 6GHz scan of the wireless device is open, we should open bug and patch kernel to disable it.

[Sylvain Pineau (sylvain-pineau)]

thanks for the rationale behing this MR.

The other (p-p-resource) MR though needs some fixing that I need to explain but here's my proposal for this new job.
the kernel and lsb releases can be extracted from checkbox own resource jobs.

unit: template
template-resource: device
template-filter: device.category == 'WIRELESS' and device.interface != 'UNKNOWN'
template-unit: job
id: wireless/check_{interface}_wifi6e_status
category_id: com.canonical.plainbox::wireless
_summary: Check the status of Wifi6e
plugin: shell
requires:
 wireless_sta_protocol.{interface}_ax_6GHz == 'supported'
 lsb.release and float(lsb.release) <= 20.04
 uname.release and float('.'.join(uname.release.split('.')[:2])) < 5.15
command:
 echo "6GHz band is enabled with kernel older than 5.15 or Ubuntu older than 20.xx"
 exit 1
estimated_duration: 2.0
_description:
 Check if the system enable Wifi6e 6GHz band with kernel older than 5.15 or
 Ubuntu older then 20.xx

review: Needs Fixing

[Jonathan Cave (jocave)]

For me the summary and description do not convey the intent of the job clearly enough as you described in https://code.launchpad.net/~dirksu/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/416512/comments/1103427

It should be obvious to a reader of a test report what the test is for and i don't "Check the status of Wifi6e" summarises this

review: Needs Fixing

Unmerged commits

adb27a8... by Dirk Su on 2022-03-14

Check the status of 802.11ax 6GHz band

check if 6Ghz band enabled with Kernel under 5.15 or Ubuntu
under 20.04

diff --git a/units/wireless/jobs.pxu b/units/wireless/jobs.pxu
index 05349b8..869ed6d 100644
--- a/units/wireless/jobs.pxu
+++ b/units/wireless/jobs.pxu
@@ -551,3 +551,27 @@ command:
 estimated_duration: 2.0
 depends: wireless/nm_connection_save_{interface}
 flags: preserve-locale also-after-suspend
+
+unit: template
+template-resource: device
+template-filter: device.category == 'WIRELESS' and device.interface != 'UNKNOWN'
+template-unit: job
+id: wireless/check_{interface}_wifi6e_status
+category_id: com.canonical.plainbox::wireless
+_summary: Check the enabled state of Wifi6e 6GHz band
+plugin: shell
+requires:
+ wireless_sta_protocol.{interface}_ax_6GHz == 'supported'
+ lsb.release and float(lsb.release) <= 20.04
+ uname.release and float('.'.join(uname.release.split('.')[:2])) < 5.15
+command:
+ echo "6GHz band is enabled with kernel under 5.15 or Ubuntu under 20.04"
+ exit 1
+estimated_duration: 2.0
+_description:
+ Ubuntu under 20.04 does not have full 6GHz stack support in userspace.
+ And Kernel under 5.15 does not have full 6GHz support in the cfg80211
+  subsystem. If the requirements of userspace and kernel space do not
+  meet, it may lead to a system able to scan 6GHz and see the AP but not
+  be able to connect to it.
+