Code review comment for ~dirksu/plainbox-provider-checkbox:check_wifi6e

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

thanks for the rationale behing this MR.

The other (p-p-resource) MR though needs some fixing that I need to explain but here's my proposal for this new job.
the kernel and lsb releases can be extracted from checkbox own resource jobs.

unit: template
template-resource: device
template-filter: device.category == 'WIRELESS' and device.interface != 'UNKNOWN'
template-unit: job
id: wireless/check_{interface}_wifi6e_status
category_id: com.canonical.plainbox::wireless
_summary: Check the status of Wifi6e
plugin: shell
requires:
 wireless_sta_protocol.{interface}_ax_6GHz == 'supported'
 lsb.release and float(lsb.release) <= 20.04
 uname.release and float('.'.join(uname.release.split('.')[:2])) < 5.15
command:
 echo "6GHz band is enabled with kernel older than 5.15 or Ubuntu older than 20.xx"
 exit 1
estimated_duration: 2.0
_description:
 Check if the system enable Wifi6e 6GHz band with kernel older than 5.15 or
 Ubuntu older then 20.xx

review: Needs Fixing

« Back to merge proposal