EPICS Base

Code review comment for ~dirk.zimoch/epics-base:epicsMutexPriorityInheritance

  1. Git
  2. lp:~dirk.zimoch/epics-base
  3. epicsMutexPriorityInheritance
  4. Merge into 7.0
Revision history for this message
Dirk Zimoch (dirk.zimoch) wrote :

I have now dropped the workaround for missing PTHREAD_MUTEX_RECURSIVE in pre 2001 Posix.

Falling back from PTHREAD_PRIO_INHERIT to PTHREAD_PRIO_NONE is still supported of course. Line 60 pthread_mutexattr_settype() will fail but that will simply result in a default mutex attribute and an error message (if errVerbose is set).

Setting PTHREAD_MUTEX_RECURSIVE in line 70 must not fail. That should not be a problem, even for rr or other special systems.

The only new external function is now called osdPosixMutexInit (not starting with "epics") and is in the private header file osdPosixMutexPriv.h which does not get installed. It is used inside libCom only.

I am not yet happy with the test. I need to find out how to use testSkip() properly when SCHED_FIFO is not available or the prority range is too limited.

There seems to be no TESTPROD_HOST_Posix (instead of TESTPROD_HOST_Linux) to run the test on all posix architectures. How to do that in the Makefile?

« Back to merge proposal