I think a smaller diff would help move the process faster, as would more targeted changes.
Personally, I'm not sure I'll accept a global pthread_mutexattr_t. I think this should become a local in epicsMutexOsdCreate() (or equivalent helper).
As a general rule, I prefer locality for various reasons. Modern processors with deep caches generally reward memory locality. Mostly though, it is a case of readability. I find it easier to understand code which doesn't reference globals.
I think a smaller diff would help move the process faster, as would more targeted changes.
Personally, I'm not sure I'll accept a global pthread_ mutexattr_ t. I think this should become a local in epicsMutexOsdCr eate() (or equivalent helper).
As a general rule, I prefer locality for various reasons. Modern processors with deep caches generally reward memory locality. Mostly though, it is a case of readability. I find it easier to understand code which doesn't reference globals.