Code review comment for ~dirk.zimoch/epics-base:iocLogClientFixesTry2
Revision history for this message
| Dirk Zimoch (dirk.zimoch) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
I did that briefly. The client (ioc) happily sends to the server and on the server the TCP input queue fills up. If the server then dies the messages are lost.
I have not tried it until the queues filled up. The the logClient may block while holding the mutex which may make errlog (or whatever client) block. I will test that.
I suggest to remove the code that attempts to send from sendMessageChunk() and accept (and report) that messages are lost.
Can you please also review the usage of the mutex in the original code. I have the impression it does not really make sense.