Code review comment for ~dirk.zimoch/epics-base:named-events-backward-compatibility
Revision history for this message
| Dirk Zimoch (dirk.zimoch) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Am 02.03.2018 um 21:31 schrieb Andrew Johnson <email address hidden>:
>
> The new Release Notes entry should go at the top of the file (where it says "Insert new items immediately below here ..."). I don't think it needs to be quite so explicit about the new algorithm, a brief description in words would suffice (I won't insist you change the text if you don't want to, but see the question below). It should mention that the post_event() routine has been undeprecated again since there may be quite a lot of older software that still calls this entry-point so we don't intend to remove it.
I‘ll change it. (On Monday)
>
> Looking at your event number compatibility logic, if I've understood the code properly it seems that I can legally create an event named "-1" or "256", although neither could be triggered by post_event(), but the names "Inf" and "Nan" are seen as illegal and will be rejected. That doesn't seem terribly logical to me, why couldn't they be allowed as purely string names?
Ralph suggested that.
>
> I haven't tried pulling the code yet, I'm assuming it builds and works as promised (I will check that on Linux at least when merging).
> --
> https:/
> You are the owner of ~dirk.zimoch/