Code review comment for lp:~directhex/libubuntuone/mono-bindings

Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

Looks good, except for one thing, which is that I'd like the mono bindings to be optional, that is:

108 +dnl Checks for Mono bindings
109 +AC_PATH_PROG(MONO_GAPI_PARSER, gapi2-parser, no)
110 +if test "x$MONO_GAPI_PARSER" = "xno"; then
111 + AC_MSG_ERROR(could not find gapi2-parser)
112 +fi
113 +
114 +AC_PATH_PROG(MONO_GAPI_CODEGEN, gapi2-codegen, no)
115 +if test "x$MONO_GAPI_CODEGEN" = "xno"; then
116 + AC_MSG_ERROR(could not find gapi2-codegen)
117 +fi
118 +
119 +AC_PATH_PROG(MONO_CSC, gmcs, no)
120 +if test "x$MONO_CSC" = "xno"; then
121 + AC_MSG_ERROR(could not find gmcs compiler)
122 +fi
123 +
124 +

and

132 +PKG_CHECK_MODULES(GTKSHARP, gtk-sharp-2.0)
133 AC_SUBST(PYGTK_CFLAGS)
134 AC_SUBST(PYGTK_LIBS)
135 +AC_SUBST(GTKSHARP_CFLAGS)
136 +AC_SUBST(GTKSHARP_LIBS)

it should check for the existence of the modules needed for the Mono bindings, but not fail, so that libu1 can be built even if those are not found, thus leaving the mono bindings unbuilt. This needs to be done also for the Python bindings though

review: Needs Fixing

« Back to merge proposal