Merge lp:~diogobaeder/ubuntu-push/auth into lp:ubuntu-push

Proposed by Diogo Baeder
Status: Merged
Approved by: Diogo Baeder
Approved revision: no longer in the source branch.
Merged at revision: 84
Proposed branch: lp:~diogobaeder/ubuntu-push/auth
Merge into: lp:ubuntu-push
Diff against target: 34 lines (+8/-5)
2 files modified
client/session/session.go (+3/-1)
protocol/messages.go (+5/-4)
To merge this branch: bzr merge lp:~diogobaeder/ubuntu-push/auth
Reviewer Review Type Date Requested Status
Samuele Pedroni Approve
Review via email: mp+211836@code.launchpad.net

Commit message

Adding authorization field to the ConnectMsg struct

Description of the change

Adding authorization field to the ConnectMsg struct

To post a comment you must log in.
lp:~diogobaeder/ubuntu-push/auth updated
82. By Samuele Pedroni

[r=chipaca] vendor the go 1.3 development net/http bits which properly/better support timeouts for requests; see _using.txt and Makefile for the recipe in http13client

83. By Samuele Pedroni

[r=chipaca] add timeing out to webhecker using the vendorized go 1.3 net/http in http13client

Revision history for this message
Samuele Pedroni (pedronis) :
review: Approve
lp:~diogobaeder/ubuntu-push/auth updated
84. By Diogo Baeder

[r=pedronis] Adding authorization field to the ConnectMsg struct

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'client/session/session.go'
--- client/session/session.go 2014-02-21 16:17:28 +0000
+++ client/session/session.go 2014-03-19 23:47:19 +0000
@@ -250,7 +250,9 @@
250 err = proto.WriteMessage(protocol.ConnectMsg{250 err = proto.WriteMessage(protocol.ConnectMsg{
251 Type: "connect",251 Type: "connect",
252 DeviceId: sess.DeviceId,252 DeviceId: sess.DeviceId,
253 Levels: levels,253 // xxx get the SSO Authorization string from the phone
254 Authorization: "",
255 Levels: levels,
254 })256 })
255 if err != nil {257 if err != nil {
256 sess.setState(Error)258 sess.setState(Error)
257259
=== modified file 'protocol/messages.go'
--- protocol/messages.go 2014-02-26 16:04:57 +0000
+++ protocol/messages.go 2014-03-19 23:47:19 +0000
@@ -27,10 +27,11 @@
2727
28// CONNECT message28// CONNECT message
29type ConnectMsg struct {29type ConnectMsg struct {
30 Type string `json:"T"`30 Type string `json:"T"`
31 ClientVer string31 ClientVer string
32 DeviceId string32 DeviceId string
33 Info map[string]interface{} `json:",omitempty"` // platform etc...33 Authorization string
34 Info map[string]interface{} `json:",omitempty"` // platform etc...
34 // maps channel ids (hex encoded UUIDs) to known client channel levels35 // maps channel ids (hex encoded UUIDs) to known client channel levels
35 Levels map[string]int6436 Levels map[string]int64
36}37}

Subscribers

People subscribed via source and target branches