Code review comment for lp:~diogobaeder/txstatsd/fix-host-lookup

Revision history for this message
Diogo Baeder (diogobaeder) wrote :

Changed again to use limit=2 in the default instance for tests, instead
of in specific tests, as requested.

Em 26-12-2012 18:39, Diogo Baeder escreveu:
> I changed it to use limit=2 instead of limit=1 because it's more
> expressive to me that the limit is actually used/respected when queueing
> the calls (if I use only 1, it's not clear that it respects the number
> given as a limit or if it closes right after the first message sent to
> the queue). This shouldn't have any noticeable impact on the test duration.
>
> Would this be OK for you?
>
> Em 26-12-2012 18:08, Sidnei da Silva escreveu:
>> You still haven't changed the test to use limit=1. :)
>

« Back to merge proposal