Code review comment for lp:~diogenesethecynical/lernid/Bug793793
Revision history for this message
| Diogenese TheCynical (diogenesethecynical) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> This isn't for sharing a url, however, it is a shortcut for someone using the
> Open Url... I don't think the browser will work with ftp:// ,etc., at this
> point anyway, but I guess it could in the future.
>
> Diogenese, you could check have urlparse do some work here and have it find
> the scheme. If it finds no scheme you could do the prepend of http:// . That
> might make the code more robust. I'm not sure this is terribly important.
Hi John
You are absolutely right. We might need to support ftp:// in future.
What do you think about this:
if URL starts with www then preappend http:// to it.
If this is not what you had in mind when you said find the scheme, please do let me know.
Regards.