Merge lp:~dinko-metalac/sudoku-app/profiles-fixes into lp:~fredoust/sudoku-app/profiles

Proposed by Dinko Osmankovic
Status: Merged
Approved by: Frédéric Delgado
Approved revision: 65
Merged at revision: 66
Proposed branch: lp:~dinko-metalac/sudoku-app/profiles-fixes
Merge into: lp:~fredoust/sudoku-app/profiles
Diff against target: 42 lines (+4/-2)
3 files modified
components/AddProfileDialog.qml (+1/-1)
components/ManageProfileDialog.qml (+1/-1)
sudoku-app.qml (+2/-0)
To merge this branch: bzr merge lp:~dinko-metalac/sudoku-app/profiles-fixes
Reviewer Review Type Date Requested Status
Frédéric Delgado Approve
Review via email: mp+173656@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dinko Osmankovic (dinko-metalac) wrote :

Hi,

I just changed DefaultSheet to be fullscreen and removed some "a"s from the labels.

Cheers,
Dinko

Revision history for this message
Frédéric Delgado (fredoust) wrote :

Hello, thanks for that.

Frédéric.

2013/7/9 Dinko Osmankovic <email address hidden>

> Hi,
>
> I just changed DefaultSheet to be fullscreen and removed some "a"s from
> the labels.
>
> Cheers,
> Dinko
> --
>
> https://code.launchpad.net/~dinko-metalac/sudoku-app/profiles-fixes/+merge/173656
> You are requested to review the proposed merge of
> lp:~dinko-metalac/sudoku-app/profiles-fixes into
> lp:~fredoust/sudoku-app/profiles.
>

--
Frédéric Delgado
http://fdelgado.fr

Revision history for this message
Frédéric Delgado (fredoust) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'components/AddProfileDialog.qml'
2--- components/AddProfileDialog.qml 2013-07-08 10:12:53 +0000
3+++ components/AddProfileDialog.qml 2013-07-09 06:57:29 +0000
4@@ -9,7 +9,7 @@
5
6 Dialog {
7 id: addProfileDialogue
8- title: i18n.tr("Add a new profile")
9+ title: i18n.tr("Add new profile")
10 width: parent.width
11
12
13
14=== modified file 'components/ManageProfileDialog.qml'
15--- components/ManageProfileDialog.qml 2013-07-08 10:12:53 +0000
16+++ components/ManageProfileDialog.qml 2013-07-09 06:57:29 +0000
17@@ -9,7 +9,7 @@
18
19 Dialog {
20 id: editProfileDialogue
21- title: i18n.tr("Edit a profile")
22+ title: i18n.tr("Edit profile")
23 width: parent.width
24
25
26
27=== modified file 'sudoku-app.qml'
28--- sudoku-app.qml 2013-07-08 15:56:42 +0000
29+++ sudoku-app.qml 2013-07-09 06:57:29 +0000
30@@ -425,6 +425,7 @@
31 id: profileSelector
32 DefaultSheet {
33 title: i18n.tr("Select profile")
34+ contentsHeight: mainView.height
35
36 /*
37 Column {
38@@ -472,6 +473,7 @@
39 id: manageProfileSelector
40 DefaultSheet {
41 title: i18n.tr("Select profile")
42+ contentsHeight: mainView.height
43
44
45

Subscribers

People subscribed via source and target branches