Code review comment for lp:~dimitern/juju-core/400-lp-1307513-multiple-nics-same-mac

Reviewers: mp+216453_code.launchpad.net,

Message:
Please take a look.

Description:
various: Support multiple NICs with the same MAC

Fixes bug #1307513, allowing more than one network
interface with the same MAC address, and introduces
the concept of virtual and physical network and NIC.
This is needed because you can have more than one
network interface with the same MAC address on the
same machine (but it has to be on different networks):
one physical and multiple virtual NICs. Changes were
needed mostly in state to use a different primary
key for networkinterfaces collection. Also added a
unique index on "interfacename" and "networkname",
improved tests.

Fixed the MAAS provider to configure networks properly,
so that you can have more than one VLAN virtual NIC
on the same physical NIC.

In a follow-up, machine addresses and networks will
be integrated, so we can link a network interface's
name and MAC address to its network (IP) address.
Finally, networks and machine interfaces will be
visible in juju status.

https://code.launchpad.net/~dimitern/juju-core/400-lp-1307513-multiple-nics-same-mac/+merge/216453

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/89260044/

Affected files (+408, -180 lines):
   A [revision details]
   M environs/broker.go
   M provider/dummy/environs.go
   M provider/maas/environ.go
   M provider/maas/environ_test.go
   M state/api/params/internal.go
   M state/api/provisioner/provisioner_test.go
   M state/apiserver/provisioner/provisioner.go
   M state/apiserver/provisioner/provisioner_test.go
   M state/machine.go
   M state/machine_test.go
   M state/networkinterfaces.go
   M state/networkinterfaces_test.go
   M state/networks.go
   M state/networks_test.go
   M state/open.go
   M state/state.go
   M state/state_test.go
   M worker/provisioner/provisioner_task.go
   M worker/provisioner/provisioner_test.go