Code review comment for lp:~dimitern/juju-core/382-api-provisioner-machine-nics

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Reviewers: mp+214272_code.launchpad.net,

Message:
Please take a look.

Description:
api/provisioner: Allow adding networks and NICs

This adds two new Provisioner API calls:
  * AddNetwork (exposed as st.AddNetworks bulk call on
    the client-side provisioner API)
  * AddNetworkInterface (exposed in the client-side API
    as machine.AddNetworkInterfaces bulk call)

These will be used to set the networks/interfaces that
will be configured by MAAS at provisioning time.

Next, we'll make the necessary changes to StartInstance()
in general (and in provider/maas specifically) to return
what networks will the machine start with.

https://code.launchpad.net/~dimitern/juju-core/382-api-provisioner-machine-nics/+merge/214272

Requires:
https://code.launchpad.net/~dimitern/juju-core/381-state-machine-nics/+merge/213796

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/84570043/

Affected files (+322, -4 lines):
   A [revision details]
   M state/api/params/internal.go
   M state/api/provisioner/machine.go
   M state/api/provisioner/provisioner.go
   M state/api/provisioner/provisioner_test.go
   M state/apiserver/provisioner/provisioner.go
   M state/apiserver/provisioner/provisioner_test.go

« Back to merge proposal