Code review comment for lp:~dimitern/juju-core/350-api-service-deploy-with-networks

Revision history for this message
Roger Peppe (rogpeppe) wrote :

https://codereview.appspot.com/76910044/diff/20001/state/api/params/params.go
File state/api/params/params.go (right):

https://codereview.appspot.com/76910044/diff/20001/state/api/params/params.go#newcode155
state/api/params/params.go:155: type ServiceDeployWithNetworks struct {
I suggest that instead of making a new set of parameters, we could just
add the networks parameters to ServiceDeploy, and make
ServiceDeployWithNetworks an alias of Deploy.

We can document the new fields as recognised only in 1.18 (1.19? 1.20?)
API servers.

This means that clients that care that the networks fields are
recognised can use ServiceDeployWithNetworks, but existing clients can
continue to use Deploy, and eventually we should be able to deprecate
ServiceDeployWithNetworks.

This adds minimal clutter to the code, and provides the same
functionality AFAICS.

https://codereview.appspot.com/76910044/

« Back to merge proposal