1) it's hard to approve this without an implementation in the background
2) should we be talking network tags?
https://codereview.appspot.com/76910044/diff/20001/state/apiserver/client/client.go File state/apiserver/client/client.go (right):
https://codereview.appspot.com/76910044/diff/20001/state/apiserver/client/client.go#newcode243 state/apiserver/client/client.go:243: return c.serviceDeploy(&args, nil) might be nicer to copy args into a ServiceDeployWithNetworks...
https://codereview.appspot.com/76910044/diff/20001/state/apiserver/client/client.go#newcode256 state/apiserver/client/client.go:256: func (c *Client) serviceDeploy(args0 *params.ServiceDeploy, args1 *params.ServiceDeployWithNetworks) error { ...and just handle one arg type here?
https://codereview.appspot.com/76910044/
« Back to merge proposal
1) it's hard to approve this without an implementation in the background
2) should we be talking network tags?
https:/ /codereview. appspot. com/76910044/ diff/20001/ state/apiserver /client/ client. go /client/ client. go (right):
File state/apiserver
https:/ /codereview. appspot. com/76910044/ diff/20001/ state/apiserver /client/ client. go#newcode243 /client/ client. go:243: return c.serviceDeploy (&args, nil) thNetworks. ..
state/apiserver
might be nicer to copy args into a ServiceDeployWi
https:/ /codereview. appspot. com/76910044/ diff/20001/ state/apiserver /client/ client. go#newcode256 /client/ client. go:256: func (c *Client) ServiceDeploy, args1 ServiceDeployWi thNetworks) error {
state/apiserver
serviceDeploy(args0 *params.
*params.
...and just handle one arg type here?
https:/ /codereview. appspot. com/76910044/