Code review comment for lp:~dimitern/juju-core/350-api-service-deploy-with-networks

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Reviewers: mp+211773_code.launchpad.net,

Message:
Please take a look.

Description:
state/api: Add Client.ServiceDeployWithNetworks

This adds a new client API call: ServiceDeployWithNetworks,
which works exactly like ServiceDeploy, but takes two extra
arguments (required) IncludedNetworks and ExcludedNetworks.
These specify a list of VLANs/networks to enable or disable
at boot time for the machine being deployed, and also record
that into the service document.

Right now, the new API does not change the service and/or
machine documents to add the networks, because there's another
branch mgz is doing for that right now.

https://code.launchpad.net/~dimitern/juju-core/350-api-service-deploy-with-networks/+merge/211773

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/76910044/

Affected files (+162, -37 lines):
   A [revision details]
   M juju/deploy.go
   M state/api/client.go
   M state/api/params/params.go
   M state/apiserver/client/client.go
   M state/apiserver/client/client_test.go
   M state/apiserver/client/perm_test.go

« Back to merge proposal