Thanks for the changes, and cleaning the code up. Looks much better now :)
Just a few little things...
https://codereview.appspot.com/72860045/diff/2/environs/bootstrap/state.go File environs/bootstrap/state.go (right):
https://codereview.appspot.com/72860045/diff/2/environs/bootstrap/state.go#newcode43 environs/bootstrap/state.go:43: logger.Debugf("putting %q to boostrap storage %#v", StateFile, storage) s/boostrap/bootstrap/
https://codereview.appspot.com/72860045/diff/2/environs/configstore/disk.go File environs/configstore/disk.go (right):
https://codereview.appspot.com/72860045/diff/2/environs/configstore/disk.go#newcode29 environs/configstore/disk.go:29: // Exists returns if the default disk-based environment config storage returns true iff?
https://codereview.appspot.com/72860045/diff/2/environs/open.go File environs/open.go (right):
https://codereview.appspot.com/72860045/diff/2/environs/open.go#newcode93 environs/open.go:93: if source != ConfigFromInfo { Is this right? You're changing behaviour here; the old code only updated the error if the existing error was non-nil.
https://codereview.appspot.com/72860045/
« Back to merge proposal
Thanks for the changes, and cleaning the code up. Looks much better now
:)
Just a few little things...
https:/ /codereview. appspot. com/72860045/ diff/2/ environs/ bootstrap/ state.go bootstrap/ state.go (right):
File environs/
https:/ /codereview. appspot. com/72860045/ diff/2/ environs/ bootstrap/ state.go# newcode43 bootstrap/ state.go: 43: logger. Debugf( "putting %q to boostrap bootstrap/
environs/
storage %#v", StateFile, storage)
s/boostrap/
https:/ /codereview. appspot. com/72860045/ diff/2/ environs/ configstore/ disk.go configstore/ disk.go (right):
File environs/
https:/ /codereview. appspot. com/72860045/ diff/2/ environs/ configstore/ disk.go# newcode29 configstore/ disk.go: 29: // Exists returns if the default
environs/
disk-based environment config storage
returns true iff?
https:/ /codereview. appspot. com/72860045/ diff/2/ environs/ open.go
File environs/open.go (right):
https:/ /codereview. appspot. com/72860045/ diff/2/ environs/ open.go# newcode93 open.go: 93: if source != ConfigFromInfo {
environs/
Is this right? You're changing behaviour here; the old code only updated
the error if the existing error was non-nil.
https:/ /codereview. appspot. com/72860045/