Code review comment for lp:~dimitern/juju-core/330-general-improvements

Revision history for this message
Andrew Wilkins (axwalk) wrote :

https://codereview.appspot.com/72860045/diff/1/environs/manual/init.go
File environs/manual/init.go (right):

https://codereview.appspot.com/72860045/diff/1/environs/manual/init.go#newcode27
environs/manual/init.go:27: cmd.Stdin =
strings.NewReader(ssh.CheckProvisionedScript)
utils/ssh is for *general ssh* things. These scripts do not belong
there. I see the case for exposing them, for the test code, but please
keep them out of utils/ssh.

https://codereview.appspot.com/72860045/

« Back to merge proposal