Code review comment for lp:~dimitern/juju-core/330-general-improvements

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Reviewers: mp+210108_code.launchpad.net,

Message:
Please take a look.

Description:
various: production code and logging improvements

Fixed 3 slightly annoying issues:
1. Refactored production code not to depend on
gocheck (manual provider and apiserver/charms).
2. Fixed and improved tools download output via
curl and better handling of errors.
3. Added debug logging to environs sshstorage and
httpstorage, and the manual provider.

Changes tested live with a manual and local environs
with added manually provisioned machines.

https://code.launchpad.net/~dimitern/juju-core/330-general-improvements/+merge/210108

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/72860045/

Affected files (+207, -177 lines):
   A [revision details]
   M environs/bootstrap/state.go
   M environs/cloudinit/cloudinit.go
   M environs/cloudinit/cloudinit_test.go
   M environs/httpstorage/storage.go
   M environs/manual/bootstrap_test.go
   D environs/manual/fakessh.go
   M environs/manual/init.go
   M environs/manual/init_test.go
   M environs/manual/provisioner_test.go
   M environs/sshstorage/storage.go
   M environs/testing/storage.go
   M provider/manual/environ.go
   M state/apiserver/charms.go
   M state/apiserver/charms_test.go
   M state/apiserver/client/client_test.go
   M utils/http.go
   M utils/ssh/ssh.go
   M utils/ssh/testing/fakessh.go
   A utils/storage/storage.go

« Back to merge proposal