Code review comment for lp:~dimitern/juju-core/270-lp-1257649-ssh-timeout-bootstrap

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Reviewers: mp+203832_code.launchpad.net,

Message:
Please take a look.

Description:
bootstrap: Added configurable timeout and delays

Fixed bug #1257649: ssh timeout for bootstrap
could be configurable, by adding 3 new config
settings:
- bootstrap-ssh-timeout (default: 600s = 10m)
- bootstrap-ssh-retry-delay (default: 5s)
- bootstrap-ssh-addresses-delay (default: 10s)

All of them are integers, measured in seconds,
and also all of them are optional and have the
specified defaults.

Updated the bootstrap command's help text to
include the new config settings.

https://code.launchpad.net/~dimitern/juju-core/270-lp-1257649-ssh-timeout-bootstrap/+merge/203832

Requires:
https://code.launchpad.net/~dimitern/juju-core/260-lp-1067979-duplicate-charm/+merge/203291

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/58170045/

Affected files (+236, -101 lines):
   A [revision details]
   M cmd/juju/bootstrap.go
   M environs/config/config.go
   M environs/config/config_test.go
   M provider/common/bootstrap.go

« Back to merge proposal