LGTM.
https://codereview.appspot.com/12748044/diff/5002/names/relation_test.go File names/relation_test.go (right):
https://codereview.appspot.com/12748044/diff/5002/names/relation_test.go#newcode16 names/relation_test.go:16: var relationIdTests = []struct { Okay, so this is a case where I like the table test style.
https://codereview.appspot.com/12748044/diff/5002/state/state.go File state/state.go (right):
https://codereview.appspot.com/12748044/diff/5002/state/state.go#newcode498 state/state.go:498: return nil, errors.NotFoundf("relation %s", id) If the conversion fails, is that really a not found rather than an invalid situation?
Is there a test exercising this branch?
https://codereview.appspot.com/12748044/
« Back to merge proposal
LGTM.
https:/ /codereview. appspot. com/12748044/ diff/5002/ names/relation_ test.go test.go (right):
File names/relation_
https:/ /codereview. appspot. com/12748044/ diff/5002/ names/relation_ test.go# newcode16 test.go: 16: var relationIdTests = []struct {
names/relation_
Okay, so this is a case where I like the table test style.
https:/ /codereview. appspot. com/12748044/ diff/5002/ state/state. go
File state/state.go (right):
https:/ /codereview. appspot. com/12748044/ diff/5002/ state/state. go#newcode498 NotFoundf( "relation %s", id)
state/state.go:498: return nil, errors.
If the conversion fails, is that really a not found rather than an
invalid situation?
Is there a test exercising this branch?
https:/ /codereview. appspot. com/12748044/