Code review comment for lp:~dimitern/juju-core/102-state-endpoint-refactoring

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Reviewers: mp+180141_code.launchpad.net,

Message:
Please take a look.

Description:
state;charm: Refactor state/Endpoint

Two methods of state.Endpoint are not related to state,
more to charm metadata. Endpoint embeds a charm.Relation,
so I moved IsImplicit() and ImplementedBy() from Endpoint
to charm.Relation, along with their tests.
This is necessary, so that we can avoid implementing API
calls for them in the uniter API facade, becasue the
uniter needs them.

https://code.launchpad.net/~dimitern/juju-core/102-state-endpoint-refactoring/+merge/180141

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/12906044/

Affected files:
   A [revision details]
   M charm/meta.go
   M charm/meta_test.go
   M state/endpoint_test.go

« Back to merge proposal