Code review comment for lp:~dimitern/juju-core/070-deployer-client-facade

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Reviewers: mp+174973_code.launchpad.net,

Message:
Please take a look.

Description:
state/api: Deployer client-side facade.

Implemented all the necessary API calls for the
deployer worker. This is the last step needed
before the deployer can be refactored to use
only the API to talk to state.

Also fixed the StringsWatcher client implementation
(I initially got it wrong, but since nobody was using
it yet it got undetected).

Few other minor issues discovered and fixed in state,
adding tests as needed.

https://code.launchpad.net/~dimitern/juju-core/070-deployer-client-facade/+merge/174973

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/11342043/

Affected files:
   A [revision details]
   A state/api/deployer/deployer.go
   A state/api/deployer/deployer_test.go
   A state/api/deployer/machine.go
   A state/api/deployer/unit.go
   M state/api/machiner/machiner.go
   M state/api/state.go
   M state/api/upgrader/upgrader_test.go
   M state/api/watcher/watcher.go
   M state/apiserver/root.go
   M state/machine.go
   M state/machine_test.go
   M state/unit.go
   M state/unit_test.go

« Back to merge proposal